degrade gracefully

1 files changed, 5 insertions, 6 deletions

diff --git a/hel/recv-media.nix b/hel/recv-media.nix
index d9ad5d29..5a9a8505 100644
--- a/hel/recv-media.nix
+++ b/hel/recv-media.nix
@@ -8,7 +8,7 @@
 , gnused ? null
 }:
 
-assert showTitle -> ffmpeg != null && gnused != null;
+assert showTitle -> ffmpeg != null && gnused != null && notifyUser != null;
 
 writeScriptBin "recv-media" ''
   #!${stdenv.shell}
@@ -33,12 +33,11 @@ writeScriptBin "recv-media" ''
     touch -c -m -t "$2" "''${target}"
   fi
 
+  ${if notifyUser == null then "" else "#"}exit 0
+  
   (
-    summary=$(ffmpeg -i "''${target}" -f ffmetadata pipe:1 2>/dev/null | sed -r '/^title=/!d; s/^title=//')
-    if [[ -z "''${summary}" ]]; then
-      echo "Title is empty, replacing with filename" >&2
-      summary=$(basename "$1")
-    fi
+    summary=$(${if showTitle then ''ffmpeg -i "''${target}" -f ffmetadata pipe:1 2>/dev/null | sed -r '/^title=/!d; s/^title=//''' else ''""'' fi)
+    [[ -z "''${summary}" ]] && summary=$(basename "$1")
     printf "%s\n%s\n" "''${summary}" "" | notify-${notifyUser} -a recv-media || true
   ) || true
 ''